Version bump nimbus-cli to 0.3.0 #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
commented
Jun 19, 2023
| @@ -167,6 +169,9 @@ cleanup() { | |||
|
|
|||
| success() { | |||
| echoProgress "Success!" | |||
| if [[ "$IS_UPGRADE" == "true" ]] ; then | |||
| echoInfo "To see What's New, visit: https://experimenter.info/nimbus-cli/whats-new" | |||
There was a problem hiding this comment.
This link won't be live until mozilla/experimenter-docs#454 lands.
jeddai
approved these changes
Jun 22, 2023
|
r+wc — would you also add a changelog entry for the version upgrade? |
jhugman
force-pushed
the
jhugman/exp-3594-version-bump-nimbus-cli
branch
from
ec2fff4
to
a5ad402
Compare
🤔 I'm not sure. I put a version bump and a link to the CLI changelog in the AS changelog. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5674 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 106 106
Lines 11277 11277
=======================================
Hits 9471 9471
Misses 1806 1806 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EXP-3594.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.