Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enrollments list to targeting attributes for nimbus #5685

Merged
merged 5 commits into from Jun 27, 2023

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented Jun 26, 2023

https://mozilla-hub.atlassian.net/browse/EXP-3599

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jeddai jeddai force-pushed the past-present-enrollment-targeting branch from 6574730 to 1f19f86 Compare June 26, 2023 21:23
@jeddai jeddai marked this pull request as ready for review June 26, 2023 21:23
@jeddai jeddai requested a review from jhugman June 26, 2023 21:25
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (2bf9814) 83.95% compared to head (c9e689b) 84.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5685      +/-   ##
==========================================
+ Coverage   83.95%   84.07%   +0.11%     
==========================================
  Files         109      109              
  Lines       11429    11413      -16     
==========================================
  Hits         9595     9595              
+ Misses       1834     1818      -16     
Impacted Files Coverage Δ
components/nimbus/src/enrollment.rs 92.29% <ø> (ø)
components/nimbus/src/evaluator.rs 91.58% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is exactly how I saw this working.

A few comments, but good job.

components/nimbus/src/tests/stateful/test_nimbus.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
components/nimbus/src/nimbus_client.rs Outdated Show resolved Hide resolved
@jeddai jeddai enabled auto-merge June 27, 2023 17:28
@jeddai jeddai added this pull request to the merge queue Jun 27, 2023
Merged via the queue into mozilla:main with commit a20e265 Jun 27, 2023
16 checks passed
@jeddai jeddai deleted the past-present-enrollment-targeting branch June 27, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants