New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add enrollments list to targeting attributes for nimbus #5685
add enrollments list to targeting attributes for nimbus #5685
Conversation
6574730
to
1f19f86
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5685 +/- ##
==========================================
+ Coverage 83.95% 84.07% +0.11%
==========================================
Files 109 109
Lines 11429 11413 -16
==========================================
Hits 9595 9595
+ Misses 1834 1818 -16
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is exactly how I saw this working.
A few comments, but good job.
https://mozilla-hub.atlassian.net/browse/EXP-3599
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.