When bucketing decreasing in a rollout, then end enrollment

[jhugman]

Fixes EXP-3450, EXP-3451.

Discussion: when an audience size reduces, we now move into status WasEnrolled. This has two effects:

• we will still be accessible via the new enrollments targeting
• the client will not be able to enroll if the bucketing goes back up again.

We should note that:

• Disqualified as a status exists (so the client can drop out of targeting), but in this case the enrollments is not sensitive to this.

Alternatives considered:

• adding a DisqualifiedReason::NotSelected, and then at some later time translating this to a WasEnrolled
• Making the enrollments targeting sensitive to Disqualified enrollments. -- both rejected on too many moving parts.
• Adding extra edges to the DFA to get from Disqualified or WasEnrolled back to Enrolled— rejected because of this may affect data quality.

/cc @jaredlockhart

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

[firefoxci-taskcluster]

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:app-services-level-1/UNYpl10AT_m59fkXbQiadw/UNYpl10AT_m59fkXbQiadw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:app-services-level-1/UNYpl10AT_m59fkXbQiadw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:app-services-level-1/UNYpl10AT_m59fkXbQiadw/UNYpl10AT_m59fkXbQiadw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:app-services-level-1/UNYpl10AT_m59fkXbQiadw"
      ]
    }
  ]
}

---

• method: rerunTask
• errorCode: InsufficientScopes
• statusCode: 403
• time: 2023-06-27T23:33:16.395Z

[codecov-commenter]

Codecov Report

Patch coverage: 97.87% and project coverage change: +51.74 🎉

Comparison is base (652b4ac) 32.75% compared to head (3edfce8) 84.50%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5687       +/-   ##
===========================================
+ Coverage   32.75%   84.50%   +51.74%     
===========================================
  Files         319      109      -210     
  Lines       30356    11816    -18540     
===========================================
+ Hits         9944     9985       +41     
+ Misses      20412     1831    -18581     

Impacted Files	Coverage Δ
components/nimbus/src/enrollment.rs	92.50% <66.66%> (+19.50%)	⬆️
components/nimbus/src/tests/helpers.rs	100.00% <100.00%> (ø)
components/nimbus/src/tests/test_enrollment.rs	98.04% <100.00%> (+0.04%)	⬆️

... and 233 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jeddai]

This looks great, tests are great! 🚢

[firefoxci-taskcluster]

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:app-services-level-1/bsWr9zoGTTuY9TdlQJasog/bsWr9zoGTTuY9TdlQJasog",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:app-services-level-1/bsWr9zoGTTuY9TdlQJasog"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:app-services-level-1/bsWr9zoGTTuY9TdlQJasog/bsWr9zoGTTuY9TdlQJasog",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:app-services-level-1/bsWr9zoGTTuY9TdlQJasog"
      ]
    }
  ]
}

---

• method: rerunTask
• errorCode: InsufficientScopes
• statusCode: 403
• time: 2023-06-28T17:11:43.860Z

[firefoxci-taskcluster]

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:app-services-level-1/bsWr9zoGTTuY9TdlQJasog/bsWr9zoGTTuY9TdlQJasog",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:app-services-level-1/bsWr9zoGTTuY9TdlQJasog"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:app-services-level-1/bsWr9zoGTTuY9TdlQJasog/bsWr9zoGTTuY9TdlQJasog",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:app-services-level-1/bsWr9zoGTTuY9TdlQJasog"
      ]
    }
  ]
}

---

• method: rerunTask
• errorCode: InsufficientScopes
• statusCode: 403
• time: 2023-06-28T17:15:06.811Z