Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rollouts to re-evaluate enrollment if they are disqualified for targeting or bucketing #5716

Merged
merged 4 commits into from Jul 12, 2023

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented Jul 6, 2023

EXP-3649

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jeddai jeddai added nimbus Nimbus, the experimentation platform. rust Pull requests that update Rust code labels Jul 6, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (069700a) 89.86% compared to head (442e0d5) 89.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5716   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files           1        1           
  Lines         148      148           
=======================================
  Hits          133      133           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests! 🥇 This looks good, I just have a few possibly stupid questions:

components/nimbus/src/enrollment.rs Outdated Show resolved Hide resolved
components/nimbus/src/enrollment.rs Outdated Show resolved Hide resolved
components/nimbus/src/enrollment.rs Outdated Show resolved Hide resolved
components/nimbus/src/nimbus_client.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

components/nimbus/src/enrollment.rs Show resolved Hide resolved
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! A few nits, but nothing too substantial. Well done!

components/nimbus/src/tests/stateful/test_nimbus.rs Outdated Show resolved Hide resolved
components/nimbus/src/tests/stateful/test_nimbus.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
components/nimbus/src/nimbus_client.rs Outdated Show resolved Hide resolved
components/nimbus/src/enrollment.rs Outdated Show resolved Hide resolved
@jeddai jeddai enabled auto-merge July 12, 2023 16:51
@jeddai jeddai added this pull request to the merge queue Jul 12, 2023
Merged via the queue into mozilla:main with commit 47f4c50 Jul 12, 2023
16 checks passed
@jeddai jeddai deleted the exp-3649-rollout-reenrollment branch July 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nimbus Nimbus, the experimentation platform. rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants