Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete iOS sync logic #5725

Merged
merged 1 commit into from Jul 17, 2023
Merged

Remove obsolete iOS sync logic #5725

merged 1 commit into from Jul 17, 2023

Conversation

lougeniaC64
Copy link
Contributor

@lougeniaC64 lougeniaC64 commented Jul 13, 2023

This is the last piece of the iOS sync manager integration work. At a high level, it removes the sync functionality we exposed for iOS prior to the sync manager integration. It includes:

  • Removing the reset, wipe, and sync functions from the swift layer of the logins component
  • Removing the sync function from the logins UDL and store files
  • Removing the syncBookmarks, syncHistory, resetHistorySyncMetadata, resetBookmarksSyncMetadata, and wipeLocalHistory functions from the swift layer of the places component
  • Removing the reset and sync functions from the swift layer of the tabs component
  • Removing the reset and sync functions from the tabs UDL and full sync module
  • Removing the full-sync tabs feature (which required updating a number of cargo files)
  • Refactoring the sync logic in the sync-pass and tabs-sync examples

NOTE: I've purposely excluded any changes that would necessitate updating A-C so that the scope of the sync manager integration effort isn't increased.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@lougeniaC64 lougeniaC64 changed the title [WIP] Remove obsolete iOS sync logic Remove obsolete iOS sync logic Jul 13, 2023
@lougeniaC64 lougeniaC64 marked this pull request as ready for review July 14, 2023 21:22
Copy link
Member

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! 🚀 🚀 Thank you for seeing this through!

@lougeniaC64 lougeniaC64 added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit cc29c69 Jul 17, 2023
17 checks passed
@lougeniaC64 lougeniaC64 deleted the remove-ios-sync-functions branch July 17, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants