Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of nimbus-cli server for iOS devices #5751

Merged
merged 4 commits into from Jul 31, 2023

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Jul 28, 2023

Fixes EXP-3615.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jhugman jhugman force-pushed the jhugman/exp-3615-nimbus-cli-server branch from e831dd9 to 5c2f6a3 Compare July 28, 2023 16:41
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 95.65% and project coverage change: -52.77% ⚠️

Comparison is base (48e15d0) 89.86% compared to head (e0f0e06) 37.09%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5751       +/-   ##
===========================================
- Coverage   89.86%   37.09%   -52.77%     
===========================================
  Files           1      330      +329     
  Lines         148    33115    +32967     
===========================================
+ Hits          133    12285    +12152     
- Misses         15    20830    +20815     
Files Changed Coverage Δ
components/support/nimbus-cli/src/config.rs 73.52% <ø> (ø)
components/support/nimbus-cli/src/main.rs 87.56% <85.71%> (ø)
components/support/nimbus-cli/src/cli.rs 86.74% <100.00%> (ø)
...mponents/support/nimbus-cli/src/output/deeplink.rs 96.66% <100.00%> (ø)

... and 326 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhugman jhugman force-pushed the jhugman/exp-3615-nimbus-cli-server branch 4 times, most recently from 1601ac3 to 2b9f794 Compare July 28, 2023 19:09
@jhugman jhugman force-pushed the jhugman/exp-3615-nimbus-cli-server branch from 2b9f794 to e0f0e06 Compare July 31, 2023 12:15
@jhugman jhugman requested review from jeddai and eliserichards and removed request for jeddai July 31, 2023 13:14
Copy link
Member

@jeddai jeddai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any code comments and it seems to work well, 🚢

@jhugman jhugman added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit de391fc Jul 31, 2023
17 checks passed
@jhugman jhugman deleted the jhugman/exp-3615-nimbus-cli-server branch July 31, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants