Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust log forwarder bindings for Focus iOS #5858

Merged
merged 1 commit into from Oct 6, 2023
Merged

Conversation

lougeniaC64
Copy link
Contributor

Fixing issue building the rust log forwarder component for Focus iOS introduced in #5840. This should resolve the error in Focus iOS PR #3875,

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cfbf109) 36.83% compared to head (c53167a) 36.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5858   +/-   ##
=======================================
  Coverage   36.83%   36.83%           
=======================================
  Files         347      347           
  Lines       33501    33501           
=======================================
  Hits        12340    12340           
  Misses      21161    21161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tarikeshaq tarikeshaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lougeniaC64 lougeniaC64 marked this pull request as ready for review October 6, 2023 18:26
@lougeniaC64 lougeniaC64 added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit a90e048 Oct 6, 2023
17 checks passed
@lougeniaC64 lougeniaC64 deleted the fix-focus-build branch October 6, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants