Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure workspaces, build on Travis #6

Merged
merged 9 commits into from
May 16, 2018
Merged

Reconfigure workspaces, build on Travis #6

merged 9 commits into from
May 16, 2018

Conversation

vladikoff
Copy link
Contributor

No description provided.

@vladikoff vladikoff requested a review from eoger April 25, 2018 21:37
@thomcc
Copy link
Contributor

thomcc commented Apr 26, 2018

We should merge this because without it the build is broken due to having multiple workspaces. (This is my fault, sorry...)

@eoger
Copy link
Contributor

eoger commented May 9, 2018

What do we want to do with this? Is still still needed?

@vladikoff
Copy link
Contributor Author

@eoger what do we need to do to make it build in this log https://travis-ci.org/mozilla/application-services/jobs/379026612 ?

@eoger
Copy link
Contributor

eoger commented May 15, 2018

From what I'm reading, executing libs/build_all.sh and passing JANSSON_DIR and CJOSE_DIR variables.

@eoger eoger force-pushed the workspace-u1 branch 3 times, most recently from 54cc3a7 to 7523910 Compare May 16, 2018 00:39
@eoger eoger force-pushed the workspace-u1 branch 3 times, most recently from 3574c24 to 06b0cf5 Compare May 16, 2018 01:23
@eoger
Copy link
Contributor

eoger commented May 16, 2018

Looks like I've managed to fix the build.
I've also cached libs/ios/ since it's very slow to build, but I think in the future we should probably have a build script that only targets x86_64 (for local/travis-ci testing).

One more thing, @vladikoff is there a particular reason we do cargo build --release and cargo test instead of just doing the latter? It makes our build even slower because for some reason it re-compiles every cargo dependency.

@vladikoff
Copy link
Contributor Author

I've also cached libs/ios/ since it's very slow to build

👍

@@ -0,0 +1,18 @@
language: rust
os: osx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we need that for lipo, but like in said in #6 (comment) we don't really need these lipoed libraries.

@vladikoff
Copy link
Contributor Author

One more thing, @vladikoff is there a particular reason we do cargo build --release and cargo test instead of just doing the latter?

Fixed it up

@vladikoff
Copy link
Contributor Author

oof

image

@vladikoff vladikoff merged commit 7642545 into master May 16, 2018
@vladikoff vladikoff deleted the workspace-u1 branch May 16, 2018 03:16
@eoger eoger mentioned this pull request May 16, 2018
dmose pushed a commit to dmose/application-services that referenced this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants