Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change manifest locations, repos and branches based on major version #6012

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Dec 20, 2023

Fixes EXP-4162.

Following the moves of firefox-ios and focus-ios, this PR adds version awareness to the manifest locations, repositories, and branch format.

All of these things have varied independently of one another.

Testing of this PR has been done only by visual inspection, with scripts like this:

min_version=108
app=focus_ios
experiment=https://experimenter.services.mozilla.com/nimbus/viewpoint-android-dec-2023
for n in $(seq $min_version 122); do
    nimbus-cli --app focus_ios --channel release validate --version $n $experiment 
done

This is due to no single experiment is valid across all versions of an app. This will change once we can feed the calculated URL (or equivalent) to the FML command line. To limit the scope of the PR this is not done here.

A speedy landing will unblock QA who will be unexpectedly blocked from testing firefox and focus experiments on iOS today.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jhugman jhugman requested a review from brennie December 20, 2023 12:34
@jhugman jhugman force-pushed the jhugman/exp-4162-add-version-aware-manifest-locations-to-nimbus-cli branch from 881c0fe to 444bc9c Compare December 20, 2023 12:37
}
}

/// pad_major_minor will zero pad the minor and patch versions if they are not present.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is wrong.

@@ -0,0 +1,67 @@
// This Source Code Form is subject to the terms of the Mozilla Public
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider using a crate like semver long term.

@jhugman jhugman force-pushed the jhugman/exp-4162-add-version-aware-manifest-locations-to-nimbus-cli branch from 444bc9c to 4ec0edb Compare December 20, 2023 17:33
@jhugman jhugman added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit e5635fa Dec 20, 2023
15 checks passed
@jhugman jhugman deleted the jhugman/exp-4162-add-version-aware-manifest-locations-to-nimbus-cli branch December 20, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants