Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimbus - Add record is ready method #6063

Merged
merged 1 commit into from Jan 19, 2024

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented Jan 18, 2024

This is a O(n) change.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jeddai jeddai added the O(n) Well-scoped logic changes label Jan 18, 2024
@jeddai jeddai force-pushed the exp-4221-add-record-is-ready-method branch 2 times, most recently from 250f15b to bdbadff Compare January 18, 2024 21:31
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (430436c) 27.63% compared to head (81a080d) 27.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6063   +/-   ##
=======================================
  Coverage   27.63%   27.63%           
=======================================
  Files         398      398           
  Lines       50186    50186           
=======================================
  Hits        13870    13870           
  Misses      36316    36316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! 💯

@jeddai jeddai force-pushed the exp-4221-add-record-is-ready-method branch from bdbadff to 81a080d Compare January 19, 2024 14:53
@jeddai jeddai enabled auto-merge January 19, 2024 14:53
@jeddai jeddai added this pull request to the merge queue Jan 19, 2024
Merged via the queue into mozilla:main with commit a281e0d Jan 19, 2024
16 checks passed
@jeddai jeddai deleted the exp-4221-add-record-is-ready-method branch January 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O(n) Well-scoped logic changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants