-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Expose webext-storage bridged engine logic #6180
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6180 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 331 331
Lines 29794 29794
=======================================
Hits 6750 6750
Misses 23044 23044 ☔ View full report in Codecov by Sentry. |
bbade2c
to
e575606
Compare
5e3e796
to
28a5329
Compare
001c524
to
70894db
Compare
3ef93c5
to
ce9babc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - just a few nits. Obviously we still need to be careful about when exactly we land this, but it looks ready to me, nice work!
19d71e5
to
1d49962
Compare
@linabutler @skhamis I'm adding you as reviewers to give you a chance to review these changes and offer any feedback. |
1d49962
to
f7b28b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @lougeniaC64! This looks super reasonable to me—I see it matches TabsBridgedEngine
concept-for-concept, which is great!
I don't think there's any hurry to consolidate them, especially since it would be nice to eventually bridge the other way—that is, use our Rust Sync code in Desktop, and have Desktop-specific engines implemented in JS—so I'm completely happy to approve this once it's out of draft!
e3e82b8
to
bc56444
Compare
bc56444
to
5244fb8
Compare
5244fb8
to
2bb90f8
Compare
Fixes SYNC-4205
Exposing the webext-storage bridged engine work for integration of the uniffi-ed components in desktop. This PR will not be merged until the desktop patch(es) to refactor the webext-storage logic and vendor in A-S are reviewed and approved.
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[firefox-android: branch-name]
to the PR title.