Bug 1390206 profile #159
Bug 1390206 profile #159
Conversation
slave/executors.py
Outdated
| # create new profile | ||
| runner.mkdir("profile/") | ||
| # Force stylo off. | ||
| prefs["layout.css.servo.enabled"] = False |
There was a problem hiding this comment.
one thing i'd maybe suggest is if we can pull this out into a separate file so it's just a case of listing out prefs and desired settings (presuming we have many more experiments in the future that we might want some control over)... there's also maybe further discussion about using a service to set our automation to the correct state (maybe even allowing remote flipping so we can effectively a/b our results)
slave/executors.py
Outdated
| @@ -134,6 +134,9 @@ def execute(self, benchmark, env, args, prefs): | |||
| # delete profile | |||
| runner.rm("profile/") | |||
|
|
|||
| # Force stylo off. | |||
| prefs["layout.css.servo.enabled"] = False | |||
There was a problem hiding this comment.
Can you put it next to the other Firefox default prefs, for consistency, please? (in configs.py)
Agreed using an external file or external service would be even better.
|
I made the changes and amended the commit and did a force push. I should have added the changes as a new commit and done a squash during the merge. I'll just do the merge now anyway. |
|
Force-pushing works great too, thanks for merging! |
The first commit changes from using a string of user_pref values in profile_ to keeping the preferences in a dictionary that is passed to FirefoxProfile to create the profile. See the bug for more details.
The second commit adds the preference prefs["layout.css.servo.enabled"] = False to prevent servo from running.