This repository has been archived by the owner on Oct 3, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Use mozinstall to extract builds (#76) #109
Open
EricRahm
wants to merge
32
commits into
mozilla:e10s
Choose a base branch
from
EricRahm:use_mozinstall
base: e10s
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Breaks out metadata into it's own columns/tables - Stores value type and kind in data table - Adds process name to data table
- Always report kind and unit - Don't convert to strings, just report the integer value
Removes intermediate conversion step.
- Process and checkpoint names are properly inserted - All new columns in benchtester_data are filled
Uses new DB fields. Currently only handles the Main process and ignores the 'kind' field.
Based on the original update_database.py script.
DB cleanup in preparation of e10s support
heap-unclassified wasn't updated to take into account the new reporting format. This just wraps it in the proper object format.
This adds the process name to the node path, ie: 'Iteration 5/StartSettled/*Main*/heap-allocated' Note: e10s currently only has one 'Main' process and one 'Web Content' process.
This also adds series datapoints of the 'Web Content' process.
Updates to handle the new datapoint format. Adds series for 'Web Content' and specifies the existing graphs are for 'Main'.
Adds handling of the process name name in the datapoint tree.
Export e10s data
Use built in |wait_for_condition| to check if the the new tab has been opened rather than a short sleep.
Prevent 'Thanks for using e10s' message from showing up. Also adds a few more e10s prefs just in case.
It's possible for the window handle to change after opening a new tab and then navigating to a real URL when e10s is enabled.
A '--process_count' argument is added to specify the amount of content processes to use with e10s enabled. The value defaults to 1.
Normalize process names to include a process number if there are multiple instances. Example mapping: [ "Main" => "Main", "Web Content (123)" => "Web Content", "Web Content (234)" => "Web Content 2", "Web Content (345)" => "Web Content 3" ] The first instance of the process name excludes the number so as to avoid breaking graph generation for the AWSY website which expects names without numbers.
Support mutilple content processes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches over some of our hardcoded paths and extensions by using mozinstall. This gets us one step closer to cross-platform support.
@nnethercote Can you please review?