WebDriver Virtual Device Implementation #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartinho
approved these changes
Sep 11, 2020
|
Thanks, Martinho. I've rebased this now on the new error changes; I'd appreciate it if you could double-check my interdiff in a158b7b. There are some outstanding clippy errors that appear since moving from rust 1.43 to 1.46, but I'll take those in a separate PR. |
|
Oops, one more: b7f5932 |
rmartinho
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a WebDriver endpoint for integration with Firefox Marinonette for Web Platform Tests.
As-is, the virtual device controls
testtoken.rswhich depends on a stub implementation ofsoftware_u2f.rsand does not support CTAP2. While all the WebDriver methods exist and have tests, when the WebDriver is enabled and commanded appropriately, only blank output gets returned. That's as-expected, and a next effort will be building out thesoftware_u2f.rsimplementation to work properly.