Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for D-Bus virtual devices #146

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ueno
Copy link

@ueno ueno commented Jan 6, 2021

This enables access to authenticator devices through the D-Bus based protocol rather than low-level communication protocols such as USB HID. The main motivation of this is to allow isolated clients (e.g., Firefox Flatpak) to run without unnecessary privileges on the host.

The D-Bus server implementation is mostly done by our colleague Norbert as part of his internship at Red Hat. The protocol is still not fixed, so use my branch if you are interested in testing it.


object_manager
.inner()
.connect_signal("InterfacesRemoved", move |message| {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, zbus should provide a more specific connect_interfaces_removed_signal here. It'd be actually super trivial to add so I'll do that today. I'll check if other signals are missing from fdo interfaces as well and add them.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can track that here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ueno Here you go. If you could test it before I merge, that would be great.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I confirm that it works with this change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, btw you also don't need .inner() call since Deref<Target=zbus::Proxy> is implemented.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zbus 1.8.0 just released has this new API now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; updated to use it.

@ueno ueno force-pushed the wip/dueno/dbus branch 7 times, most recently from dc06312 to 49013dc Compare January 12, 2021 06:47
This allows alternative token implementations to use CTAP2 based API,
that expects relying party is hashed by the platform, not by the
application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants