Add support for D-Bus virtual devices #146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
reviewed
Jan 6, 2021
src/virtualdevices/dbus/dbus.rs
Outdated
|
|
||
| object_manager | ||
| .inner() | ||
| .connect_signal("InterfacesRemoved", move |message| { |
There was a problem hiding this comment.
Oh, zbus should provide a more specific connect_interfaces_removed_signal here. It'd be actually super trivial to add so I'll do that today. I'll check if other signals are missing from fdo interfaces as well and add them.
There was a problem hiding this comment.
@ueno Here you go. If you could test it before I merge, that would be great.
There was a problem hiding this comment.
Yes, I confirm that it works with this change.
There was a problem hiding this comment.
Cool, btw you also don't need .inner() call since Deref<Target=zbus::Proxy> is implemented.
There was a problem hiding this comment.
zbus 1.8.0 just released has this new API now.
ueno
force-pushed
the
wip/dueno/dbus
branch
7 times, most recently
from
dc06312
to
49013dc
Compare
This allows alternative token implementations to use CTAP2 based API, that expects relying party is hashed by the platform, not by the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables access to authenticator devices through the D-Bus based protocol rather than low-level communication protocols such as USB HID. The main motivation of this is to allow isolated clients (e.g., Firefox Flatpak) to run without unnecessary privileges on the host.
The D-Bus server implementation is mostly done by our colleague Norbert as part of his internship at Red Hat. The protocol is still not fixed, so use my branch if you are interested in testing it.