Add riscv64 support #152
Merged
Add riscv64 support #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dveditz ping |
rmartinho
added a commit
that referenced
this pull request
Jun 20, 2022
* Add riscv64 support (#152) Thanks! * Fix panic msg is not a string literal warning (#149) Fixes the non_fmt_panic warning. * Update rand. (#164) * Use memoffset instead of homebrew offset_of (#171) Co-authored-by: R. Martinho Fernandes <bugs@rmf.io> * Remove base64 from dev-dependencies, as it is now a normal dependency * Bump application-services to the version currently vendored in mozilla-central Co-authored-by: Makoto Kato <m_kato@ga2.so-net.ne.jp> Co-authored-by: est31 <est31@users.noreply.github.com> Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io> Co-authored-by: R. Martinho Fernandes <rmf@rmf.io> Co-authored-by: R. Martinho Fernandes <bugs@rmf.io> Co-authored-by: Martin Sirringhaus <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To generate riscv64 code, rust-bindgen have to be updated due to rust-lang/rust-bindgen#1878. risc64's rust target is risc64gc-*, but clang doesn't accept this target name since correct is riscv64, not riscv64gc.