Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #27: Remove min Fx version from targeting #35

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix #27: Remove min Fx version from targeting #35

merged 1 commit into from
Aug 4, 2023

Conversation

m-d-bowerman
Copy link
Collaborator

Removes the minimum version from targeting recipes. This also removes the minimum version from the results JSON, so these changes shouldn't be merged until changes are made to ingestion to remove the key.

mikewilli
mikewilli approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll check out the experimenter side and we can get this merged before the next run.

@m-d-bowerman m-d-bowerman merged commit a409688 into main Aug 4, 2023
1 check passed
@m-d-bowerman m-d-bowerman deleted the 27_remove_versions branch August 4, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewilli mikewilli mikewilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-d-bowerman @mikewilli