Add descriptions of targets to README #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewilli
reviewed
Jul 3, 2024
README.md
Outdated
Comment on lines
21
to
24
| Currently, pre-computed size calculation supports targeting clients on locale, country, channel, or user type, which includes new or existing clients. New clients are defined | ||
| as clients whose first seen date is during the 7 day enrollment period of the size calculation analysis; existing clients are defined as clients whose first seen date was at least | ||
| 28 days before the first date of enrollment in the size calculation analysis. For any target dimension, the string `'all'` can be included to omit that condition from client selection. | ||
|
|
There was a problem hiding this comment.
Looks good, but I think we should put this in the top section as a paragraph after line 3
This tool automatically calculates sizing for experiments.
mikewilli
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds descriptions of the dimensions available for targeting for pre-computed sizes to README.md. Included in that description are the definitions of new and existing clients, as well as the option to omit dimensions from size calculation.