Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

Commit

Permalink
Bug 1161631 - Autophone - Make PhoneTest use PhoneWorkerSubProcess in…
Browse files Browse the repository at this point in the history
…stance of ADBAndroid, r=gbrown.
  • Loading branch information
bclary committed Jun 1, 2015
1 parent ef6e338 commit 0f03d7f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 21 deletions.
21 changes: 2 additions & 19 deletions phonetest.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ def __init__(self, phone, options, config_file=None, chunk=1, repos=[]):
self.loggerdeco.info('init autophone.phonetest')
self._base_device_path = ''
self.profile_path = '/data/local/tmp/profile'
self._dm = None
self.repos = repos
self._log = None
# Treeherder related items.
Expand Down Expand Up @@ -230,7 +229,7 @@ def _add_instance(self, phoneid, config_file, chunk):

def _check_device(self):
for attempt in range(1, self.options.phone_retry_limit+1):
output = self._dm.get_state()
output = self.dm.get_state()
if output == 'device':
break
self.loggerdeco.warning(
Expand All @@ -250,18 +249,7 @@ def name(self):

@property
def dm(self):
if not self._dm:
self.loggerdeco.info('PhoneTest: Connecting to %s...' % self.phone.id)
self._dm = ADBDevice(device=self.phone.serial,
logger_name='autophone.phonetest.adb',
device_ready_retry_wait=self.options.device_ready_retry_wait,
device_ready_retry_attempts=self.options.device_ready_retry_attempts,
verbose=self.options.verbose)
# Override mozlog.logger
self._dm._logger = self.loggerdeco
self.loggerdeco.info('PhoneTest: Connected.')
self._check_device()
return self._dm
return self.worker_subprocess.dm

@property
def base_device_path(self):
Expand Down Expand Up @@ -486,11 +474,6 @@ def teardown_job(self):
if self.dm_logger_original:
self.dm._logger = self.dm_logger_original

def set_dm_debug(self, level):
self.options.debug = level
if self._dm:
self._dm.log_level = level

def update_status(self, phone_status=None, message=None):
if self.update_status_cb:
self.update_status_cb(build=self.build,
Expand Down
2 changes: 0 additions & 2 deletions worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -720,8 +720,6 @@ def handle_cmd(self, request, current_test=None):
# update any existing ADB objects
if self.dm:
self.dm.log_level = self.options.debug
for t in self.tests:
t.set_dm_debug(self.options.debug)
return {'interrupt': False, 'reason': ''}
if request[0] == 'ping':
self.loggerdeco.info('Pinging at user\'s request...')
Expand Down

0 comments on commit 0f03d7f

Please sign in to comment.