Bug 1461406: Show aliases for scheduled changes to rules. #761
Conversation
|
That test failure is fallout from #375 and the newly added Python 3.6 tests, and not to do with your patch. |
|
Oh! makes sense now. Thank you |
There was a problem hiding this comment.
Hmm, I think this actually introduces a new bug, and doesn't fix the reported on. Removing this line here means that when someone clicks "Schedule Duplication", the alias isn't removed (which will cause an error when they try to submit).
The bug you're looking to fix happens when you try to Schedule an Update for a Rule on http://localhost:8080/rules. If you change the alias as part of that scheduled update, it will not show up correctly until a page refresh. For example, here is the Rules page after scheduling an update before a refresh: https://screenshots.firefox.com/zz5Bbl74u1NchALD/localhost
And after: https://screenshots.firefox.com/0V9YOZRmiSpc7UK5/localhost
|
Gotcha! Will push a patch for this ASAP. Thanks for the clarification. 👍 |
|
@mozbhearsum You can feel free to take another look at this now. Thanks! |
Resolves https://bugzilla.mozilla.org/show_bug.cgi?id=1461406