Bug 1266063 - send e-mail when a release changes from read only to read write #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1304,10 +1304,35 @@ def __repr__(self): | |||
| return self.__str__() | |||
|
|
|||
|
|
|||
| def make_change_notifier(relayhost, port, username, password, to_addr, from_addr): | |||
| def send_email(relayhost, port, username, password, to_addr, from_addr, table, subj, | |||
There was a problem hiding this comment.
Nice work refactoring this to reduce duplication.
|
We talked on IRC a bit about this. Varun pointed out that the existing e-mail notifiers do a select(), so we're not going to be blocking on that. Given that, and the most recent change that adjusts this to only notify when releases are going back to rw, this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.