This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Remove FxOS workaround now that bug 962225 is fixed. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmclanahan r? |
|
I'd be a lot more comfortable if we left this here, but maybe added some statsd in that block to see how often it happens. The problem is that while that bug is fixed, it was released as part of FxOS 1.2 or 1.3 (I don't remember). So until all devices are updated to at least whatever version it was fixed in, we'll still potentially get these malformed requests. |
|
Looks from the bug like it was 1.3. |
|
Makes sense, I'll come back to this at some point. |
Osmose
force-pushed
the
remove-fxos-workaround
branch
from
e07b0e3
to
28a0cf1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading through
subscribeand noticed that bug 962225 is fixed now, so this workaround code can go away, yeah?