You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
dpoirier
wants to merge
1
commit into
mozilla:master
from
dpoirier:bug-742951-change-email
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready to review, but not to merge. The triggered email sends don't work for brand new email addresses (that aren't in ET yet), and the confirmation messages in ET are just placeholders, not the final text.
I'm wondering if we need the activation thing to be so complex, and whether we need them to hang around. I'm thinking perhaps all we need is for a row to be created when a change is requested, and to be considered active if it's been less than CONFIRMATION_DAYS (or whatever). Then we run a daily cron to delete the expired ones, and they delete themselves when they complete successfully. We can log success and failure activity, but I don't think we need for this table to just grow, and having that status column seems superfluous.
This is currently blocked because ET won't let us send a triggered email to an address that's not already in our data at ET (as best i can tell, see this bug comment). Waiting for jdavis to respond.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to review, but not to merge. The triggered email sends don't work for brand new email addresses (that aren't in ET yet), and the confirmation messages in ET are just placeholders, not the final text.