tabzila.js compareVersion function doesn't recognize jQuery 1.10.x

[hannosch]

In

bedrock/bedrock/tabzilla/templates/tabzilla/tabzilla.js

Line 381 in d2738cd

var compareVersion = function (a, b) {

there is a compareVersion function which tries to determine if a new enough jQuery version was already loaded by the site. The minimumJQuery is currently defined as '1.7.1'. My site had already loaded '1.10.2'. The compareVersion doesn't cast the version strings to numbers, but compares strings. Which leads to:

"10" > "7"
false
"10" < "7"
true

where as usually you'd get:

"9" > "7"
true
"9" < "7"
false

Maybe the function should add something like parseInt(a[i], 10) to the comparison.

[alexgibson]

Thanks for the report, @hannosch!

I've filed a bug for this here: https://bugzilla.mozilla.org/show_bug.cgi?id=942745

We'll look to get this resolved asap.

[alexgibson]

Merged in #1436

Thanks again @hannosch