-
Notifications
You must be signed in to change notification settings - Fork 2
Update marian with binary model loading #11
Commits on Jan 20, 2021
-
Import sources from mts adaptation
This first commit imports files from mts which was repurposed for bergamot translator from https://github.com/browsermt/mts/tree/nuke.
Jerin Philip committedJan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for 601bd52 - Browse repository at this point
Copy the full SHA 601bd52View commit details -
Bumping marian with sentencepiece capable fork
Modifications to SentencePiece are necessary to provide token level string_views. This commit changes marian to an alternate branch which has the feature incorporated.
Jerin Philip committedJan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for d786f25 - Browse repository at this point
Copy the full SHA d786f25View commit details -
Updating CMakeLists to build main
CMakeLists have been modified with the necessary includes to add browsermt/mts@nuke files to the bergamot-translator library. In addition, adds the ssplit dependency, corresponding includes. Intel MKL fails on compilation, unable to find libraries. To solve this 3rd_party/CMakeLists.txt is modified with @UG's fixes to propogate variables (EXT_LIBS, etc) at a library level.
Jerin Philip committedJan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for bde9094 - Browse repository at this point
Copy the full SHA bde9094View commit details -
Undoing LineSplitter, reverting SentenceSplitter.
A faster linesplitter added for benchmarks is removed in favour of @UG's ssplit-cpp. NOTE: ssplit-cpp's regex based implementation is slow for one-line parses, which ideally needs to be improved in upstream ssplit-cpp to trivially reduce to a faster newline character based split.
Jerin Philip committedJan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for b25b227 - Browse repository at this point
Copy the full SHA b25b227View commit details -
Adding documentation and example to service.h
Jerin Philip committedJan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for b3f1905 - Browse repository at this point
Copy the full SHA b3f1905View commit details -
Jerin Philip committed
Jan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for d3c707f - Browse repository at this point
Copy the full SHA d3c707fView commit details -
Commit modifies the example test-code main-mts into the app folder, updating CMakeLists accordingly.
Jerin Philip committedJan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for 54a6c6c - Browse repository at this point
Copy the full SHA 54a6c6cView commit details -
Jerin Philip committed
Jan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for caa03e1 - Browse repository at this point
Copy the full SHA caa03e1View commit details -
Removed Alignments, too many questions and no concrete answers. Better off removing unused code. History is kept for now, for internal use.
Jerin Philip committedJan 20, 2021 Configuration menu - View commit details
-
Copy full SHA for d6ec007 - Browse repository at this point
Copy the full SHA d6ec007View commit details
Commits on Jan 21, 2021
-
Vocabs was earlier loaded in each thread and copied several times. Modified this to be loaded only once in Service and reference used consistently later on. This change makes Tokenizer as a class rather moot, as there's only one private member and a function. Moved this into TextProcessor. SentenceSplitter, however remains a separate class. utils.{h,cpp} had only a single loadVocabularies function, which is at the moment required only in Service. Making loadVocabularies a function inside Service and getting rid of utils.*.
Jerin Philip committedJan 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 4640ae4 - Browse repository at this point
Copy the full SHA 4640ae4View commit details -
Neaten TextProcessor, add a bit of docs.
- Truncating long sentences into those of a specified length for faster processing is now a separate function, for improved readability. - Changes doing push_back -> emplace_back at places to avoid copy. - query_to_segments is renamed as process. - Comments are added in an attempt to bring some sanity.
Jerin Philip committedJan 21, 2021 Configuration menu - View commit details
-
Copy full SHA for ea1a628 - Browse repository at this point
Copy the full SHA ea1a628View commit details -
MTranslationResult, more comments
Jerin Philip committedJan 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 9b18bd9 - Browse repository at this point
Copy the full SHA 9b18bd9View commit details -
Fixing compile error, need tests, CI
Jerin Philip committedJan 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 12e7e2c - Browse repository at this point
Copy the full SHA 12e7e2cView commit details -
Removing unused variable in batch_translator
Jerin Philip committedJan 21, 2021 Configuration menu - View commit details
-
Copy full SHA for 80125e2 - Browse repository at this point
Copy the full SHA 80125e2View commit details
Commits on Jan 22, 2021
-
Only the bergamot-translator library should be linked to main target Any other library (marian ${MARIAN_CUDA_LIB} ${EXT_LIBS} ssplit pcrecpp.a pcre.a) should be linked to bergamot-translator target inside src/translator folder.
Jerin Philip committedJan 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 3714393 - Browse repository at this point
Copy the full SHA 3714393View commit details -
Adding vim temporary files to .gitignore
Jerin Philip committedJan 22, 2021 Configuration menu - View commit details
-
Copy full SHA for e75bd7e - Browse repository at this point
Copy the full SHA e75bd7eView commit details -
Updating README.md with instructions to run service-cli
Jerin Philip committedJan 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 3b6b9cd - Browse repository at this point
Copy the full SHA 3b6b9cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8fc004 - Browse repository at this point
Copy the full SHA c8fc004View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c3b656 - Browse repository at this point
Copy the full SHA 1c3b656View commit details -
Removing Exception to fix Apple compile
Jerin Philip committedJan 22, 2021 Configuration menu - View commit details
-
Copy full SHA for 988e76b - Browse repository at this point
Copy the full SHA 988e76bView commit details
Commits on Jan 23, 2021
-
Enables Mac and Ubuntu CPU only builds through GitHub CI. CI scripts are copied from marian-dev with necessary changes. 3rd-party/marian-dev is modified to meet C++17 requirements modifying for half_float.
Jerin Philip committedJan 23, 2021 Configuration menu - View commit details
-
Copy full SHA for 7e2eb02 - Browse repository at this point
Copy the full SHA 7e2eb02View commit details -
Jerin Philip committed
Jan 23, 2021 Configuration menu - View commit details
-
Copy full SHA for cd025e9 - Browse repository at this point
Copy the full SHA cd025e9View commit details
Commits on Jan 24, 2021
-
Changing code-style to clang-format-google
Jerin Philip committedJan 24, 2021 Configuration menu - View commit details
-
Copy full SHA for 69adc7a - Browse repository at this point
Copy the full SHA 69adc7aView commit details
Commits on Jan 25, 2021
-
Integrating marian-translator through API
Using std::string for config. Now capable of launching marian translator through API interface. There's a sketchy workaround to convert a string config to marian::Options, with an added note.
Jerin Philip committedJan 25, 2021 Configuration menu - View commit details
-
Copy full SHA for 08a7358 - Browse repository at this point
Copy the full SHA 08a7358View commit details
Commits on Jan 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 026f1af - Browse repository at this point
Copy the full SHA 026f1afView commit details -
Cleanup TranslationModelConfiguration to std::string change in API
- Provide yaml formatted string as model configuration - Remove redundant files
Configuration menu - View commit details
-
Copy full SHA for b49f2c1 - Browse repository at this point
Copy the full SHA b49f2c1View commit details -
- Print original and translated text - Just add 2 vector entries for texts
Configuration menu - View commit details
-
Copy full SHA for 0d16b19 - Browse repository at this point
Copy the full SHA 0d16b19View commit details -
Fix for garbled output through cli.
Requirement for string_view is the original source string be transferred all the way from input to service to back to TranslationResult. This constraint was violated in several places by means of existence of a copy-constructor. The issue is fixed by deleting copy and assignment constructors in marian::bergamot::TranslationResult and UnifiedAPI::TranslationResult, which demonstrated a few occurances of the same. Replaced the same with move semantics. In addition, future is set and get using move semantics at the moment. Default move-constructor didn't seem to be working, so they're made explicit for TranslationResults. This commit additionally packs a few deletions and improvements made to improve structure (textops.cpp, batcher.cpp) along the process of inspecting and fixing the garbled outputs. They are choose to be kept, in the interest of time, against a prettified atomic commit engineering. Combinations of the following commits in jp/string-view-bug [acfc92 78a588 12d91b 00a277 919e2f 9d3a46 b7e39b 18f67b bf667c]
Jerin Philip committedJan 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 9a17f36 - Browse repository at this point
Copy the full SHA 9a17f36View commit details
Commits on Jan 28, 2021
-
Jerin Philip committed
Jan 28, 2021 Configuration menu - View commit details
-
Copy full SHA for e76a602 - Browse repository at this point
Copy the full SHA e76a602View commit details
Commits on Feb 2, 2021
-
Jerin Philip committed
Feb 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 548c888 - Browse repository at this point
Copy the full SHA 548c888View commit details -
Reordering git submodule update before includes
Jerin Philip committedFeb 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 2929077 - Browse repository at this point
Copy the full SHA 2929077View commit details
Commits on Feb 8, 2021
-
- Switch to "wasm" branch of browsermt/marian-dev
Configuration menu - View commit details
-
Copy full SHA for 9a54d21 - Browse repository at this point
Copy the full SHA 9a54d21View commit details
Commits on Feb 9, 2021
-
Changed encodePreservingSource -> encodeWithByteRanges
- This change happened because marian submodule changed this name - Native builds are working fine -- bergamot-translator-app output is consistent
Configuration menu - View commit details
-
Copy full SHA for 47b4bae - Browse repository at this point
Copy the full SHA 47b4baeView commit details
Commits on Feb 10, 2021
-
Updated ssplit submodule to a different repository
- Added abhi-agg/ssplit-cpp - Added its wasm branch in bergamot-translator - Native builds of bergamot-translator are successful -- Sentence splitting is NOT WORKING -- Only translation is working
Configuration menu - View commit details
-
Copy full SHA for 5683168 - Browse repository at this point
Copy the full SHA 5683168View commit details -
Changed translate() API from non-blocking to blocking
- Can be changed back to non-blocking once blocking API becomes integrable via WASM port in browser
Configuration menu - View commit details
-
Copy full SHA for 584700c - Browse repository at this point
Copy the full SHA 584700cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2d3269 - Browse repository at this point
Copy the full SHA a2d3269View commit details
Commits on Feb 11, 2021
-
Add cmake option to compile project on WASM
- Set cmake option COMPILE_WASM to ON to compile the project on WASM
Configuration menu - View commit details
-
Copy full SHA for 9747d9b - Browse repository at this point
Copy the full SHA 9747d9bView commit details -
Set cmake option to compile marian library only
- Set COMPILE_LIBRARY_ONLY to ON for marian library
Configuration menu - View commit details
-
Copy full SHA for b73d4f4 - Browse repository at this point
Copy the full SHA b73d4f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 838547e - Browse repository at this point
Copy the full SHA 838547eView commit details -
- Make native builds successful with marian decoder - COMPILE_DECODER_ONLY flag requires importing some compile definitions from marian
Configuration menu - View commit details
-
Copy full SHA for 9b89650 - Browse repository at this point
Copy the full SHA 9b89650View commit details -
cmake compile option changes for wasm builds
- Make WASM builds successful with marian decoder - Setting COMPILE_WASM to ON requires importing some compile definitions from marian
Configuration menu - View commit details
-
Copy full SHA for 79c445a - Browse repository at this point
Copy the full SHA 79c445aView commit details -
Fixed a bug in TranslationModel class
- Using bergamot-translator as a library fails at run time because necessary parser options are not set
Configuration menu - View commit details
-
Copy full SHA for a06530e - Browse repository at this point
Copy the full SHA a06530eView commit details -
Source code changes to compile the project without threads
- Set COMPILE_THREAD_VARIANT cmake option to ON to compile multithreaded variant of the project
Configuration menu - View commit details
-
Copy full SHA for 23a9527 - Browse repository at this point
Copy the full SHA 23a9527View commit details -
Added code to generate proper JS bindings of translator
- COMPILE_WASM cmake option sets WASM_BINDINGS compile definition that enables code for generating proper JS bindings
Configuration menu - View commit details
-
Copy full SHA for 7b80003 - Browse repository at this point
Copy the full SHA 7b80003View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74b06d8 - Browse repository at this point
Copy the full SHA 74b06d8View commit details -
Added JS binding files and cmake infrastructure to build them
- Added "wasm" folder - Contains README file as well
Configuration menu - View commit details
-
Copy full SHA for de501e8 - Browse repository at this point
Copy the full SHA de501e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e126470 - Browse repository at this point
Copy the full SHA e126470View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff95e37 - Browse repository at this point
Copy the full SHA ff95e37View commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 28dcf55 - Browse repository at this point
Copy the full SHA 28dcf55View commit details -
- This fixes the issue of sentencepiece not being able to checkout properly
Configuration menu - View commit details
-
Copy full SHA for 3b7673b - Browse repository at this point
Copy the full SHA 3b7673bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9108d9f - Browse repository at this point
Copy the full SHA 9108d9fView commit details -
Merge pull request #20 from browsermt/andrenatal-patch-1
Update README.md
Configuration menu - View commit details
-
Copy full SHA for f43dc33 - Browse repository at this point
Copy the full SHA f43dc33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a53a68 - Browse repository at this point
Copy the full SHA 3a53a68View commit details
Commits on Feb 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a97bf7b - Browse repository at this point
Copy the full SHA a97bf7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47db659 - Browse repository at this point
Copy the full SHA 47db659View commit details
Commits on Feb 14, 2021
-
Including a more elaborated test page, a node webserver containing th…
…e proper cors headers and wasm mimetype
Configuration menu - View commit details
-
Copy full SHA for 1e413f7 - Browse repository at this point
Copy the full SHA 1e413f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dbc861 - Browse repository at this point
Copy the full SHA 0dbc861View commit details
Commits on Feb 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d27a96f - Browse repository at this point
Copy the full SHA d27a96fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7c8651 - Browse repository at this point
Copy the full SHA f7c8651View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26ea5bb - Browse repository at this point
Copy the full SHA 26ea5bbView commit details -
Add support for translating multiple sentences on the test page + rep…
…ort words per second metric in the log
Configuration menu - View commit details
-
Copy full SHA for d3969bc - Browse repository at this point
Copy the full SHA d3969bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28c0ab2 - Browse repository at this point
Copy the full SHA 28c0ab2View commit details -
Add instructions on how to assemble and package the set of files expe…
…cted by the test page
Configuration menu - View commit details
-
Copy full SHA for a33b3a3 - Browse repository at this point
Copy the full SHA a33b3a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53e0b9f - Browse repository at this point
Copy the full SHA 53e0b9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e50dd09 - Browse repository at this point
Copy the full SHA e50dd09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7030fa0 - Browse repository at this point
Copy the full SHA 7030fa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49ad651 - Browse repository at this point
Copy the full SHA 49ad651View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77f3954 - Browse repository at this point
Copy the full SHA 77f3954View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbdcdab - Browse repository at this point
Copy the full SHA dbdcdabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70bdcd4 - Browse repository at this point
Copy the full SHA 70bdcd4View commit details -
Finally found the original typo that made it appear as if loading the…
… model in the test page was faster than elsewhere - the lexical shortlist was not being included at the right place in the model config
Configuration menu - View commit details
-
Copy full SHA for da56501 - Browse repository at this point
Copy the full SHA da56501View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e94d78 - Browse repository at this point
Copy the full SHA 1e94d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcc998f - Browse repository at this point
Copy the full SHA fcc998fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3ff1d2 - Browse repository at this point
Copy the full SHA f3ff1d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d6346d - Browse repository at this point
Copy the full SHA 7d6346dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64d57d8 - Browse repository at this point
Copy the full SHA 64d57d8View commit details -
Enabled simd shuffle pattern for intgemm compilation
- WORMHOLE cmake option is set to ON when compiling for WASM - WASM module might not run on Chrome
Configuration menu - View commit details
-
Copy full SHA for 3dd7a60 - Browse repository at this point
Copy the full SHA 3dd7a60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91e45cb - Browse repository at this point
Copy the full SHA 91e45cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a5ae95 - Browse repository at this point
Copy the full SHA 9a5ae95View commit details -
Revert "Enabled simd shuffle pattern for intgemm compilation"
This reverts commit 3dd7a60.
Configuration menu - View commit details
-
Copy full SHA for 9a5cf30 - Browse repository at this point
Copy the full SHA 9a5cf30View commit details -
Merge pull request #26 from motin/wasm-integration
Turn of assertions and disable exception catching for wasm builds
Configuration menu - View commit details
-
Copy full SHA for fc3ab33 - Browse repository at this point
Copy the full SHA fc3ab33View commit details -
- Includes try/catch free builds - Has ASSERTION=0 and DISABLE_EXCEPTION_CATCHING=1 for wasm builds
Configuration menu - View commit details
-
Copy full SHA for 0374ac4 - Browse repository at this point
Copy the full SHA 0374ac4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3607523 - Browse repository at this point
Copy the full SHA 3607523View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5c5339 - Browse repository at this point
Copy the full SHA c5c5339View commit details
Commits on Feb 16, 2021
-
Updated config for min inference time
- This combination gives min inference time (~ 200 WPS) on local machine
Configuration menu - View commit details
-
Copy full SHA for 921c2ee - Browse repository at this point
Copy the full SHA 921c2eeView commit details -
Updated instructions on how to get all relevant models in place for t…
…he upcoming release
Configuration menu - View commit details
-
Copy full SHA for b1e72ce - Browse repository at this point
Copy the full SHA b1e72ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for d907400 - Browse repository at this point
Copy the full SHA d907400View commit details
Commits on Feb 17, 2021
-
- Clears up the spaghetti of model packaging - Usage instructions - Formatting changes
Configuration menu - View commit details
-
Copy full SHA for b86f8a7 - Browse repository at this point
Copy the full SHA b86f8a7View commit details -
Allow using relative paths for packaging files
- PACKAGE_DIR cmake option can now accept relative paths
Configuration menu - View commit details
-
Copy full SHA for 9feebe5 - Browse repository at this point
Copy the full SHA 9feebe5View commit details
Commits on Feb 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b75e72e - Browse repository at this point
Copy the full SHA b75e72eView commit details -
Replaced "build-wasm-docker" with "build-wasm"
- Now things are consistent with the top level README instructions that suggest to build in "build-wasm" folder
Configuration menu - View commit details
-
Copy full SHA for c2371dd - Browse repository at this point
Copy the full SHA c2371ddView commit details -
- Clarified that the Demo and API usage section assumes bergamot models were packaged into wasm binary - Formatting changes
Configuration menu - View commit details
-
Copy full SHA for 79571ba - Browse repository at this point
Copy the full SHA 79571baView commit details -
Remove Docker-based builds since they are no more reproducible than m…
…etal builds. Fixes browsermt/bergamot-translator#31
Configuration menu - View commit details
-
Copy full SHA for 51f702e - Browse repository at this point
Copy the full SHA 51f702eView commit details
Commits on Feb 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 896df30 - Browse repository at this point
Copy the full SHA 896df30View commit details -
Configuration menu - View commit details
-
Copy full SHA for f823c29 - Browse repository at this point
Copy the full SHA f823c29View commit details -
Configuration menu - View commit details
-
Copy full SHA for ece8240 - Browse repository at this point
Copy the full SHA ece8240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 826d322 - Browse repository at this point
Copy the full SHA 826d322View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdd0953 - Browse repository at this point
Copy the full SHA cdd0953View commit details
Commits on Feb 20, 2021
-
Merge pull request #1 from mozilla/wasm-circle-builds
WASM CircleCI builds
Configuration menu - View commit details
-
Copy full SHA for bed48e1 - Browse repository at this point
Copy the full SHA bed48e1View commit details