Increase event_property threshold #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholtzan
commented
Nov 4, 2021
| @@ -108,7 +108,7 @@ per_event_property AS ( | |||
| USING | |||
| (category, event, event_property) | |||
| WHERE | |||
| event_property_value_index <= 1000 | |||
| event_property_value_index <= 5000 | |||
There was a problem hiding this comment.
Also open to setting a different threshold
There was a problem hiding this comment.
I am slightly nervous about unintended consequences here of raising the limit by 5x, but I don't see why it would a problem apriori. It does seem reasonable to set a higher limit.
wlach
suggested changes
Nov 4, 2021
scholtzan
force-pushed
the
event-history-cap
branch
from
65dec29
to
3cba89e
Compare
|
Right, right |
wlach
approved these changes
Nov 4, 2021
| @@ -7,28 +7,28 @@ fenix_derived: | |||
| start_date: 2020-01-01 | |||
| skipped_properties: | |||
| - time_ms | |||
| max_property_values: 1000 | |||
| max_property_values: 5000 | |||
There was a problem hiding this comment.
Let's keep these values the same for everything other than Firefox desktop.
| @@ -108,7 +108,7 @@ per_event_property AS ( | |||
| USING | |||
| (category, event, event_property) | |||
| WHERE | |||
| event_property_value_index <= 1000 | |||
| event_property_value_index <= 5000 | |||
There was a problem hiding this comment.
I am slightly nervous about unintended consequences here of raising the limit by 5x, but I don't see why it would a problem apriori. It does seem reasonable to set a higher limit.
scholtzan
force-pushed
the
event-history-cap
branch
from
3cba89e
to
02ceeba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if increasing this threshold has any implications?