DENG-774 Change Control for active_users_aggregates #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucia-vargas-a
commented
Mar 28, 2023
scholtzan
reviewed
Mar 28, 2023
Comment on lines
33
to
35
| def is_github_identity(s): | ||
| """Check if the given string matches the format of a Github identity.""" | ||
| return re.match(r"[mozilla]+\/[a-zA-Z0-9]+", s) |
There was a problem hiding this comment.
In the Airflow task we need to filter out the Github teams otherwise DAGs cannot be generated
There was a problem hiding this comment.
I prefer we include the @ prefix that github uses for github identities. I assume we already have some normalization logic for labels that propagate to GCP if that's the reason we've omitted it.
bochocki
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
This LGTM! I don't think I fully understand how all the pieces fit together with the bigger picture (e.g. I wouldn't have caught @scholtzan's comment about the Airflow task), but from what I'm able to follow it looks great. I just had a few minor refactoring suggestions.
scholtzan
reviewed
Mar 28, 2023
scholtzan
reviewed
Mar 28, 2023
scholtzan
reviewed
Mar 28, 2023
scholtzan
reviewed
Mar 28, 2023
Integration report for "Merge branch 'main' into DENG-774_map_labels_and_owners"
|
lucia-vargas-a
commented
Mar 29, 2023
Integration report for "DENG-774 Update test property."
|
whd
reviewed
Mar 30, 2023
Comment on lines
33
to
35
| def is_github_identity(s): | ||
| """Check if the given string matches the format of a Github identity.""" | ||
| return re.match(r"[mozilla]+\/[a-zA-Z0-9]+", s) |
There was a problem hiding this comment.
I prefer we include the @ prefix that github uses for github identities. I assume we already have some normalization logic for labels that propagate to GCP if that's the reason we've omitted it.
Integration report for "DENG-774 Syntax improvements and use of readlines() to read CODEOWNERS."
|
scholtzan
approved these changes
Mar 31, 2023
Integration report for "Merge branch 'main' into DENG-774_map_labels_and_owners"
|
whd
reviewed
Apr 7, 2023
…into DENG-774_map_labels_and_owners
Integration report for "Merge branch 'main' into DENG-774_map_labels_and_owners"
|
Integration report for "DENG-774 Update DAGs and notification."
|
Integration report for "DENG-774 Require at least on owner instead of exactly one."
|
whd
reviewed
Apr 13, 2023
Integration report for "DENG-774 Add tests scenarios and consider lines in CODEOWNERS starting with #."
|
Integration report for "DENG-774 Syntax update."
|
whd
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
r+wc
Thank you for adding the tests. I think it's important to decide whether to require only owners in CODEOWNERS, but I don't think that needs another round of review if a test is added.
After this is merged https://github.com/mozilla/bigquery-etl/settings/branch_protection_rules/4491948 should be updated to require the validate-metadata check since it isn't required presently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DENG-774
For modifications to schemas in restricted namespaces (see
CODEOWNERS):