Implement fxa_amplitude_user_ids table #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklukas
added a commit
to mozilla/telemetry-airflow
that referenced
this pull request
May 11, 2020
jklukas
force-pushed
the
fxa-id-first-seen
branch
from
460e639
to
ce531b8
Compare
jklukas
added a commit
to mozilla/telemetry-airflow
that referenced
this pull request
May 12, 2020
fbertsch
requested changes
May 12, 2020
| SELECT | ||
| user_id | ||
| FROM | ||
| fxa_amplitude_user_ids_v1 |
There was a problem hiding this comment.
Looks like we're missing an init.sql here.
jklukas
added a commit
to mozilla/telemetry-airflow
that referenced
this pull request
May 12, 2020
And we refactor the sync send tab view to use this new table, pulling it under the `firefox_accounts` namespace.
jklukas
force-pushed
the
fxa-id-first-seen
branch
from
ce531b8
to
43a82e6
Compare
|
Added init.sql. Ready for review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And we refactor the sync send tab view to use this new table, pulling it under the
firefox_accountsnamespace.