Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow protocols and svg properties to be configurable. #122

Closed
wants to merge 1 commit into from
Closed

Allow protocols and svg properties to be configurable. #122

wants to merge 1 commit into from

Conversation

davestgermain
Copy link

I wanted to allow data URIs in images, and in order to do that I had to be able to set allowed_protocols and plumb it through to the sanitizer. While I was in there, I made the allowed_svg_properties attribute configurable, too.

@mdxs mdxs mentioned this pull request Jul 1, 2014
@willkg
Copy link
Member

willkg commented Dec 2, 2015

Adding support for protocols is being covered more comprehensively in #149. I think I'm inclined to continue moving on that there.

What's the use case for adding svg properties?

@willkg
Copy link
Member

willkg commented Feb 18, 2016

@davestgermain What's the use case for adding svg properties?

@willkg
Copy link
Member

willkg commented Apr 18, 2016

I'm going to close this out because it has merge conflicts, unanswered questions and it fails CI.

If you want to continue working on this, can you write up an issue so we can figure out what the problem being solved is, then we can work on solutions.

Thank you! Sorry for not moving this forward faster.

@willkg willkg closed this Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants