rework dev dependencies (#620) #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some additional files and directories that should be covered by Python formatting. Change flake8 line length to 88 to match black. Change flake8 to ignore line length--it's handled by black.
Previously, we maintained dev dependencies in a .in file and then used pip-compile to generate a requirements file and then used that for building dev environments and CI test environments. We hit dependencies that have different dependencies depending on Python version and interpreter. That breaks with the compiled requirements method. This redoes dev requirements so that they're an extra specified in setup.py. We don't need to track dependencies of dependencies or hash dev dependencies. We can update dev dependencies as we need to. Having stable pinned versions reduces unexpected errors because the universe changed. Developers will need to do: pip install -e '.[dev]' now to pick up dev dependencies.
|
I updated the branch requirements and removed the checks that no longer get run and added the new pypy checks. |
For Python 3.7, Sphinx, flake8, and pytest all have a importlib-metadata requirement, but they conflict. This attempts to fix that.
This changes package installation in CI so that the lint and test workflows match.
|
\o/ victory! |
|
@g-k How does this look? Are there other bits of documentation that talk about the old way to install dev dependencies that I missed? |
g-k
approved these changes
Feb 10, 2022
| @@ -2,7 +2,6 @@ include CHANGES | |||
| include CONTRIBUTORS | |||
| include CONTRIBUTING.rst | |||
| include CODE_OF_CONDUCT.rst | |||
| include requirements-dev.txt | |||
There was a problem hiding this comment.
👍 idk why we shipped this to begin with
There was a problem hiding this comment.
If someone ran check-manifest, it might have complained and suggested we add it or something like that.
|
Thank you! |
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we maintained dev dependencies in a
.infile and then used pip-compile to generate a requirements file and then used that for building dev environments and CI test environments.We hit dependencies that have different dependencies depending on Python version and interpreter. That breaks with the compiled requirements method.
This redoes dev requirements so that they're an extra specified in
setup.py. We don't need to track dependencies of dependencies or hash dev dependencies. We can update dev dependencies as we need to. Having stable pinned versions reduces unexpected errors because the universe changed.Developers will need to do:
now to pick up dev dependencies.