add urlparse tests based on wpt url tests (#668) #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"new_value" is a terrible name. I changed it to "noramlized_uri" which is a bit more along the lines of what it is.
|
@g-k Is this along the lines of what you were thinking? If you skim through the file, what other ones would be good to add in this pass? |
g-k
approved these changes
Jun 26, 2022
| path: str = "" | ||
| params: str = "" | ||
| query: str = "" | ||
| fragment: str = "" |
There was a problem hiding this comment.
Nice! I think this makes the table-based tests cleaner.
Possible future TODO would be to capture errors in this class like a Rust Result, but I guess Python usually avoids that?
There was a problem hiding this comment.
Oh, that's a good idea. I'll add a failure test and see how that might work.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 20 of the wpt url tests. There are like a thousand of them. We probably should add more, but it needs to be done manually because the parse results have a different shape and theirs factor in a base url. I added comments on some output differences I saw.