Skip to content

Commit

Permalink
Don't run preview deployments for Dependabot PRs
Browse files Browse the repository at this point in the history
They don't have access to the credentials needed for deployment
(because the updated dependencies could exploit those).
  • Loading branch information
Vinnl committed May 17, 2024
1 parent e5eab85 commit c89b429
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/preview_deploy_gcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ jobs:
deploy:
permissions:
pull-requests: write
# Secrets aren't available for Dependabot PR (because the updated
# dependencies might abuse them), so they don't have enough rights to
# do a preview deployment:
if: github.actor != 'dependabot[bot]'
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/preview_deploy_gcp_cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ jobs:
deploy:
permissions:
pull-requests: write
# Secrets aren't available for Dependabot PR (because the updated
# dependencies might abuse them), so they don't have enough rights to
# do a preview deployment:
if: github.actor != 'dependabot[bot]'
runs-on: ubuntu-latest
steps:
- name: Setup Cloud SDK
Expand Down

0 comments on commit c89b429

Please sign in to comment.