Mntor 1505/legacy cleanup #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
reviewed
Apr 21, 2023
There was a problem hiding this comment.
🎉
Still needs some work to update the CI scripts and add back some missing dependencies, but very happy to see this! And proper ES modules too 👏
Locally it seems to work fine when I run it, but I get an error when trying to run npm test:
testFileCount: testFiles.length,
^
TypeError: Cannot read properties of undefined (reading 'length')
Also RIP @maxxcrawford's artisanal, handcrafted logos.
Co-authored-by: Vincent <Vinnl@users.noreply.github.com>
toufali
force-pushed
the
MNTOR-1505/legacy-cleanup
branch
from
6d09866
to
d612dfa
Compare
rhelmer
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-1505
Description
Legacy file/folder cleanup.
Still left to do (so far):
fix testsHow to test