Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-2925 - add a function for checking the session and logging more… #4178

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

rhelmer
Copy link
Collaborator

@rhelmer rhelmer commented Feb 8, 2024

… diagnostics

References:

Jira: MNTOR-2925

Description

Start to move to a common function to check if the session is valid, and log a more detailed reason if it is not. I've implemented in the least-invasive way, but I'd like to move all of these checks to a common function as a next step once we determine the problem.

@rhelmer rhelmer requested a review from mansaj February 8, 2024 23:16
@rhelmer rhelmer self-assigned this Feb 8, 2024
Copy link
Collaborator

@mansaj mansaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reminder to revert this after diagnosis

@mansaj mansaj merged commit 9d1f12f into main Feb 8, 2024
13 checks passed
@mansaj mansaj deleted the check-session-diagnostics branch February 8, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants