Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case insensitive email #4186

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix: case insensitive email #4186

merged 2 commits into from
Feb 9, 2024

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Feb 9, 2024

References:

Jira: MNTOR-
Figma:

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@mansaj mansaj requested a review from rhelmer February 9, 2024 18:32
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind filing a followup ticket to:

  1. look at the impact on the postgres stats (I suspect the index won't be as effective)
  2. normalize the table if we can't adjust the index for (1)

I'm going to file one to consider moving to fxa uid instead of using primary_email as an identifier, I think it'd be a more stable identifier and email has undesirable properties like this.

@mansaj mansaj merged commit 1f32a89 into main Feb 9, 2024
13 checks passed
@mansaj mansaj deleted the email-case-insensitive branch February 9, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants