Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send tab-view telemetry on the server #4210

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Don't send tab-view telemetry on the server #4210

merged 4 commits into from
Feb 14, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Feb 14, 2024 •
edited
Loading

References:

Jira: MNTOR-2957
Figma: N/A

Description

This reverts #4207 (the workaround, in bf81246) and #4130 (the actual bug, in b3dedc5 - also see Slack), and then re-implements the latter's behaviour in the correct way (b671a1d).

How to test

I'm not sure how the 500 errors can be reproduced, but you should at least no longer see errors about accessing window in the Node console.

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Vinnl and others added 3 commits February 14, 2024 14:14
@Vinnl
Revert "MNTOR-2957 - avoid loading client-side analytics on server (#…
bf81246 
…4207)"

This reverts commit 280edb4.
@Vinnl
Revert "Add missing dashboard view event (#4130)"
b3dedc5 
This reverts commit fd1737b.
@Vinnl
Don't send tab-view telemetry on the server
b671a1d 
It was previously sent in the render function of
<TabContentActionNeeded>, which meant both that it would get sent
on every state object or prop change, but also that it would get
called when pre-rendering the content on the server.
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Feb 14, 2024
@Vinnl Vinnl self-assigned this Feb 14, 2024
rhelmer
rhelmer approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks for fixing this up!

@Vinnl Vinnl merged commit 47618b0 into main Feb 14, 2024
13 checks passed
@Vinnl Vinnl deleted the revert-4207-MNTOR-2957/avoid-loading-client-analytics-on-server branch February 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhelmer rhelmer rhelmer approved these changes

@flozia flozia Awaiting requested review from flozia

@mansaj mansaj Awaiting requested review from mansaj

Assignees

@Vinnl Vinnl

Labels
Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vinnl @rhelmer