Unblock Node upgrade by adding arbitrary c8 ignores #4234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like c8 is now inconsistent in what it reports as uncovered, but these additions are probably still a good idea.
flozia
reviewed
Feb 21, 2024
flozia
approved these changes
Feb 21, 2024
The Node 20.10 upgrade suddenly started marking them as uncovered. It's unclear what exactly the cause is, but there's a bug on file that might be related: istanbuljs/v8-to-istanbul#236
Vinnl
force-pushed
the
c8-inconsistent
branch
from
ae9d73c
to
35f1b73
Compare
Vinnl
merged commit 2ef458c
into
dependabot/docker/node-20.11-alpine
5 of 6 checks passed
Vinnl
added a commit
that referenced
this pull request
Mar 6, 2024
As we add code, more existing code suddenly gets marked as uncovered by unit tests intermittently. This adds c8 ignore comments for everything that turned up when running npm test -- --no-cache --runInBand But I really hope this gets fixed upstream soon, because this isn't sustainable. For more context, see: #4234 And the (hopefully correct) upstream issue: istanbuljs/v8-to-istanbul#236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade to Node 20.10, suddenly it started reporting code as uncovered that was previously not, and most of which I'm fairly sure is actually covered by unit tests. I think it's probably caused by this issue, but it's fairly hard to debug. By running
npm test -- --runInBand --no-cache(thanks @flozia) I was able to get consistent reports of uncovered lines, and thus was able to at least get back to a point where it's meeting the thresholds again - but hopefully this won't make it harder to find which new code we still need to write tests for in the future.I did leave some more diagnostic information in the upstream issue, and it refers to a number of other people running into what seems to be the same issue, so hopefully they'll find a fix there before we run into it again.