Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a story to test the progress bar #4272

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add a story to test the progress bar #4272

merged 1 commit into from
Mar 4, 2024

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Feb 26, 2024

It's a bit hard to test since you have to run the manual scan to get to the progress bar, so with a separate story, we can at least see what it looks like when loading.

I added this to try and verify #4271, but though it probably isn't the best way to verify that specific case, I figured the story might still be useful.

View it live at https://deploy-preview-4272--fx-monitor-storybook.netlify.app/?path=/story/progress-bar--progress-bar.

@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Feb 26, 2024
@Vinnl Vinnl requested a review from codemist February 26, 2024 17:28
@Vinnl Vinnl self-assigned this Feb 26, 2024
Copy link
Collaborator

@codemist codemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! It makes it easier to test.

It's a bit hard to test since you have to run the manual scan to
get to the progress bar, so with a separate story, we can at least
see what it looks like when loading.
@Vinnl Vinnl merged commit 4de6571 into main Mar 4, 2024
15 checks passed
@Vinnl Vinnl deleted the progressbar-storybook branch March 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants