MNTOR-2945: add del subscription api and unsub before deleting an user

[mansaj]

References:

Jira: MNTOR-2945

Description

Implement the unsubscribe feature correctly as a part of deletion, so the user

1. won't be billed again when signing up again
2. won't have any pre-existing records of Plus account

Screenshot (if applicable)

Not applicable.

How to test

In heroku, use a new account to subscribe to Plus. Delete that account. Watch for unsubscribe email to come through from FxA

Checklist (Definition of Done)

• Commits in this PR are minimal and have descriptive commit messages.
• I've added or updated the relevant sections in readme and/or code comments
• Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
• All acceptance criteria are met.
• Jira ticket has been updated (if needed) to match changes made during the development process.
• Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

[Vinnl]

Unfortunately it appears like I'm getting an error when trying it locally - shouldn't the request to FxA be authenticated somehow?

And I think we also don't want to try unsubscribing if we just got a notification from FxA that the user has been unsubscribed?

(And a small question: won't this a bit too noisy for our logs?)

[Vinnl]

Thanks, the code makes sense to me now. But when I try it out locally, I'm getting

deleteSubscriber error: delete from "subscribers" where "fxa_uid" = $1 returning "id" - update or delete on table "subscribers" violates foreign key constraint "onerep_scans_onerep_profile_id_foreign" on table "onerep_scans"

I wonder if we're missing a cascade somewhere to also delete scans and scan results when we delete a subscriber?

[mansaj]

Thanks, the code makes sense to me now. But when I try it out locally, I'm getting

deleteSubscriber error: delete from "subscribers" where "fxa_uid" = $1 returning "id" - update or delete on table "subscribers" violates foreign key constraint "onerep_scans_onerep_profile_id_foreign" on table "onerep_scans"

I wonder if we're missing a cascade somewhere to also delete scans and scan results when we delete a subscriber?

Hmm interesting.. Is the db migration up to date? npm run db:migrate?

[mansaj]

@Vinnl I also refactored the code a little bit so the GET call is now separate and reusable.. in case one day we do want to address the unsubscribe vs. resubscribe CTA in settings

[rhelmer]

I don't understand how we're sure the subscription ID is for the monitor subscription. Have you tested this with an account that is subscribed to multiple services?

We should really convert this to typescript and use the newer formatting rules, is that already in our tech debt epic? That part isn't a blocker for this PR, but not being able to use structured logging here is annoying.

[mansaj]

@rhelmer Thanks for catching that, verified the fix in heroku just now. The unsub works

I don't understand how we're sure the subscription ID is for the monitor subscription. Have you tested this with an account that is subscribed to multiple services?

We should really convert this to typescript and use the newer formatting rules, is that already in our tech debt epic? That part isn't a blocker for this PR, but not being able to use structured logging here is annoying.