MNTOR-2851 - Add clearer aria label for modal/dialog/tooltip triggers #4357
Conversation
locales/en/dashboard.ftl
Outdated
| @@ -43,8 +43,9 @@ modal-fixed-number-of-exposures-title = About your number of fixed exposures | |||
| modal-fixed-number-of-exposures-all = This chart includes the total number of data breaches that have been fixed for all email addresses you’re currently monitoring. Once exposures are marked as fixed, they’ll be added to the total here. | |||
|
|
|||
| modal-cta-ok = OK | |||
| modal-open-alt = Open | |||
| modal-close-alt = Close | |||
| modal-open-alt = Open modal | |||
There was a problem hiding this comment.
You need new IDs to change existing string
https://mozilla-l10n.github.io/documentation/localization/making_string_changes.html
locales/en/dashboard.ftl
Outdated
| @@ -43,8 +43,13 @@ modal-fixed-number-of-exposures-title = About your number of fixed exposures | |||
| modal-fixed-number-of-exposures-all = This chart includes the total number of data breaches that have been fixed for all email addresses you’re currently monitoring. Once exposures are marked as fixed, they’ll be added to the total here. | |||
|
|
|||
| modal-cta-ok = OK | |||
| # Obsolete | |||
There was a problem hiding this comment.
Why do we need to keep around the old string? Is it used anywhere?
|
Is it possible to have Anna test this in Storybook? The ticket is pretty unclear in that it doesn't suggest a better label, but I have a hunch that this isn't it. If you hear "Here's what we fixed. Open, button, collapsed", it isn't really clear what that does, but "Here's what we fixed. Open modal, button, collapsed" still is pretty confusing. Since the dialog title is "About what we fixed", maybe that would work for the trigger button as well? But maybe check with Anna. |
|
Made some changes and checked with Anna. Results should be what's expected. |
References:
Jira: MNTOR-2851
How to test
Checklist (Definition of Done)