Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-2781 - Use BillingPeriod component for UpsellDialog pricing section #4367

Merged
merged 4 commits into from Apr 5, 2024

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Mar 25, 2024

…ggle

References:

Jira: MNTOR-2781 and MNTOR-2484

Description

We have a dedicated component for the pricing toggle <BillingPeriod> which is used on the landing page, which meets the accessibility requirements that the previous iteration for the pricing toggle on the UpsellDialog did not. I leveraged that component instead of the old TabsList.

Screenshot (if applicable)

image

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist requested a review from Vinnl March 25, 2024 15:15
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, for some reason I expected this to have more deleted lines. But it works well!

@codemist codemist merged commit d49c656 into main Apr 5, 2024
13 checks passed
@codemist codemist deleted the mntor-2781-2847-2848 branch April 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants