Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an experiment, rather than a flag, for the last scan date #4443

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Use an experiment, rather than a flag, for the last scan date #4443

merged 11 commits into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. Define experiment for showing the last scan date

    @Vinnl
    Vinnl committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9f6d537 View commit details
    Browse the repository at this point in the history

  2. Derive experimentation ID from subscriber ID 

    Co-authored-by: Robert Helmer <rhelmer@mozilla.com>
    @Vinnl @rhelmer
    Vinnl and rhelmer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0176717 View commit details
    Browse the repository at this point in the history

  3. Rename userId cookie to experimentationId 

    Co-authored-by: Robert Helmer <rhelmer@mozilla.com>
    @Vinnl @rhelmer
    Vinnl and rhelmer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0a1d9a4 View commit details
    Browse the repository at this point in the history

  4. Pass locale and country code to Nimbus 

    This allows them to be used to select experiment cohors.

Co-authored-by: Robert Helmer <rhelmer@mozilla.com>
    @Vinnl @rhelmer
    Vinnl and rhelmer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4e5048c View commit details
    Browse the repository at this point in the history

  5. Use experiment, not flag, for last scan date

    @Vinnl
    Vinnl committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d914f52 View commit details
    Browse the repository at this point in the history

  6. Make sure generated code is available in tests

    @Vinnl
    Vinnl committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    be01556 View commit details
    Browse the repository at this point in the history

  7. Pass the experimentation ID to Glean 

    Co-authored-by: Robert Helmer <rhelmer@mozilla.com>
    @Vinnl @rhelmer
    Vinnl and rhelmer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    51aef9b View commit details
    Browse the repository at this point in the history

  8. Rename getUserId.tsx to getExperimentationId.ts

    @Vinnl
    Vinnl committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    08fc530 View commit details
    Browse the repository at this point in the history

  9. Stop sending user_id on page.view events 

    Co-authored-by: Robert Helmer <rhelmer@mozilla.com>
    @Vinnl @rhelmer
    Vinnl and rhelmer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6eeebb0 View commit details
    Browse the repository at this point in the history

  10. Rename userId to experimentationId 

    Co-authored-by: Robert Helmer <rhelmer@mozilla.com>
    @Vinnl @rhelmer
    Vinnl and rhelmer committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ed04f71 View commit details
    Browse the repository at this point in the history

  11. Make sure generated code is available in Storybook

    @Vinnl
    Vinnl committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a518253 View commit details
    Browse the repository at this point in the history