Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show CSAT survey only to active Plus subscribers (MNTOR-3191) #4516

Merged
merged 6 commits into from
May 13, 2024
Merged

Show CSAT survey only to active Plus subscribers (MNTOR-3191) #4516

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92bf7a9
fix: Show the CSAT survey banner only to users that an active Plus su…
flozia May 10, 2024
77dd9f6
Merge branch 'main' into mntor-3191
flozia May 13, 2024
0322800
chore: Use hasPremium check in place
flozia May 13, 2024
0c13c36
Merge branch 'main' into mntor-3191
flozia May 13, 2024
879b301
Merge branch 'main' into mntor-3191
flozia May 13, 2024
c65ad37
Merge branch 'main' into mntor-3191
flozia May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/app/(proper_react)/(redesign)/(authenticated)/user/(dashboard)/dashboard/View.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,10 @@ export const View = (props: Props) => {
const l10n = useL10n();
const recordTelemetry = useTelemetry(props.experimentationId);
const countryCode = useContext(CountryCodeContext);
const isPlusUser = hasPremium(props.user);

const adjustedScanResults = props.userScanData.results.map((scanResult) => {
if (scanResult.status === "new" && hasPremium(props.user)) {
if (scanResult.status === "new" && isPlusUser) {
// Even if the user has Plus, OneRep won't automatically start removing
// found exposures; it first sends a request to our webhook, and then the
// webhook sends an opt-out request to OneRep. Meanwhile, however, we're
Expand Down Expand Up @@ -189,7 +190,7 @@ export const View = (props: Props) => {
isPremiumBrokerRemovalEnabled={props.enabledFeatureFlags.includes(
"PremiumBrokerRemoval",
)}
isPremiumUser={hasPremium(props.user)}
isPremiumUser={isPlusUser}
rhelmer marked this conversation as resolved.
Show resolved Hide resolved
isEligibleForPremium={props.isEligibleForPremium}
resolutionCta={
<Button
Expand Down Expand Up @@ -404,6 +405,7 @@ export const View = (props: Props) => {
};

const showCsatSurvey =
isPlusUser &&
rhelmer marked this conversation as resolved.
Show resolved Hide resolved
props.enabledFeatureFlags.includes("CsatSurvey") &&
selectedTab === "fixed" &&
typeof props.elapsedTimeInDaysSinceInitialScan !== "undefined";
Expand Down Expand Up @@ -448,7 +450,7 @@ export const View = (props: Props) => {
<DashboardTopBanner
tabType={selectedTab}
scanInProgress={initialScanInProgress}
isPremiumUser={hasPremium(props.user)}
isPremiumUser={isPlusUser}
isEligibleForPremium={canSubscribeToPremium({
user: props.user,
countryCode,
Expand Down
Loading