-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNTOR-3210, MNTOR-3211: E2E cron failure alerts and warning fixes. #4640
Conversation
Preview URL 🚀 : https://blurts-server-pr-4640-mgjlpikfea-uk.a.run.app |
9fc1dce
to
96bc007
Compare
d5540b3
to
6d5a2fe
Compare
@@ -49,7 +48,7 @@ jobs: | |||
- name: Run Playwright tests - ${{ inputs.environment != null && inputs.environment || 'stage' }} | |||
if: github.actor != 'dependabot[bot]' | |||
run: npm run e2e | |||
timeout-minutes: 20 | |||
timeout-minutes: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a suite timeout, or could we remove it? (Random q: not PR blocking)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we do because tests are stuck idling when they reach certain states. See https://github.com/mozilla/blurts-server/actions/runs/9421692534, the application error state on the webpage causes the tests to get stuck? Not sure why the test and job keeps running.
Also not sure why thats happening because we have a test timeout limit here, https://github.com/mozilla/blurts-server/blob/main/playwright.config.js#L27-L28.
45559a2
to
5eb3a33
Compare
2b6a035
to
9308f62
Compare
Cleanup completed - database 'blurts-server-pr-4640' destroyed, cloud run service 'blurts-server-pr-4640' destroyed |
References:
Jira: MNTOR-3210, MNTOR-3211
Description
Adds an alert sent to #monitor-alerts in slack when the e2e cron fails. Fix for flaky tests and made retries for tests a 1 instead of 2.
Screenshot (if applicable)
Not applicable.
How to test
Test pass except paypal ones
https://github.com/mozilla/blurts-server/actions/runs/9408352400
Checklist (Definition of Done)