Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3210, MNTOR-3211: E2E cron failure alerts and warning fixes. #4640

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

rafeerahman
Copy link
Collaborator

@rafeerahman rafeerahman commented Jun 6, 2024

References:

Jira: MNTOR-3210, MNTOR-3211

Description

Adds an alert sent to #monitor-alerts in slack when the e2e cron fails. Fix for flaky tests and made retries for tests a 1 instead of 2.

Screenshot (if applicable)

Not applicable.

How to test

  • Run this in the GHA tab against this branch.

Test pass except paypal ones

https://github.com/mozilla/blurts-server/actions/runs/9408352400

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

Copy link

github-actions bot commented Jun 6, 2024

@rafeerahman rafeerahman force-pushed the e2e-slack-integration-and-CI-fixes branch 2 times, most recently from 9fc1dce to 96bc007 Compare June 6, 2024 18:13
@rafeerahman rafeerahman force-pushed the e2e-slack-integration-and-CI-fixes branch 3 times, most recently from d5540b3 to 6d5a2fe Compare June 6, 2024 22:33
@@ -49,7 +48,7 @@ jobs:
- name: Run Playwright tests - ${{ inputs.environment != null && inputs.environment || 'stage' }}
if: github.actor != 'dependabot[bot]'
run: npm run e2e
timeout-minutes: 20
timeout-minutes: 30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a suite timeout, or could we remove it? (Random q: not PR blocking)

Copy link
Collaborator Author

@rafeerahman rafeerahman Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we do because tests are stuck idling when they reach certain states. See https://github.com/mozilla/blurts-server/actions/runs/9421692534, the application error state on the webpage causes the tests to get stuck? Not sure why the test and job keeps running.

Also not sure why thats happening because we have a test timeout limit here, https://github.com/mozilla/blurts-server/blob/main/playwright.config.js#L27-L28.

.github/workflows/e2e_cron.yml Outdated Show resolved Hide resolved
.github/workflows/e2e_pr.yml Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@rafeerahman rafeerahman force-pushed the e2e-slack-integration-and-CI-fixes branch from 45559a2 to 5eb3a33 Compare June 10, 2024 11:29
@rafeerahman rafeerahman force-pushed the e2e-slack-integration-and-CI-fixes branch from 2b6a035 to 9308f62 Compare June 10, 2024 11:51
@rafeerahman rafeerahman merged commit 1a8f813 into main Jun 10, 2024
15 checks passed
@rafeerahman rafeerahman deleted the e2e-slack-integration-and-CI-fixes branch June 10, 2024 11:56
Copy link

Cleanup completed - database 'blurts-server-pr-4640' destroyed, cloud run service 'blurts-server-pr-4640' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants