Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3164 - “Submit Form” button for the cancel survey is cut #4641

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

mozilloid
Copy link
Collaborator

@mozilloid mozilloid commented Jun 7, 2024

References:

Jira: MNTOR-3164
Figma:

Description

Changed the default feedback text iFrame height to 280px, and 260px for large screens. - this way the submit button seems to be visible for any change in textbox size, while also not looking weird. NEEDS verification on windows device

Screenshot (if applicable)

image

How to test

Go to premium account's settings, click on cancel subscription (locally, enable the appropriate feature flags).

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@mozilloid mozilloid requested a review from codemist June 7, 2024 01:04
@mozilloid mozilloid self-assigned this Jun 7, 2024
@mozilloid mozilloid requested a review from flozia June 7, 2024 01:07
Copy link

github-actions bot commented Jun 7, 2024

@mozilloid mozilloid requested a review from pdehaan June 7, 2024 23:26
@mozilloid mozilloid marked this pull request as ready for review June 10, 2024 21:01
Copy link
Collaborator

@codemist codemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@mozilloid mozilloid merged commit 8fe2029 into main Jun 13, 2024
15 checks passed
@mozilloid mozilloid deleted the mntor-3164 branch June 13, 2024 23:22
Copy link

Cleanup completed - database 'blurts-server-pr-4641' destroyed, cloud run service 'blurts-server-pr-4641' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants