This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
fixing test to add response headers and response.url #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx - can you print out what it'll look like with the current run, which fails? Does it match the output from the other tests, which @bobsilverberg fixed in #29 ? |
|
@brandonsavage on stage the query params are blank. dev works though |
| @@ -140,4 +140,6 @@ def test_redirect_for_windows_200_to_2001(self, testsetup): | |||
|
|
|||
| parsed_url = urlparse(response.url) | |||
|
|
|||
| Assert.true('20.0.1' in parsed_url.query, 'Redirect failed using params of %s' % (parsed_url.query)) | |||
| Assert.contains('20.0.1', response.url, | |||
| '\n %s' % self.response_info(response)) | |||
There was a problem hiding this comment.
To be pep8 compliant you should indent the line a bit more - also it appears that you used tabs instead of spaces
|
@m8ttyB retornam@69f159f has fixes for the whole file. |
|
Nice! Merging |
m8ttyB
pushed a commit
that referenced
this pull request
Apr 11, 2013
fixing test to add response headers and response.url
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.