mozilla/thimble.mozilla.org#2581 - Added CSSAtRuleCodeHints and CSSPseudoSelectorHints to bramble extensions #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
approved these changes
Dec 19, 2017
There was a problem hiding this comment.
This looks great to me. Can you do me a favour? Before we land it, can you record two small animated-GIFs showing how each one of these works in a CSS file (use licecap or whatever) and put it in this PR. I want @flukeout to see it.
After that, we should be good to land this. Nice work!
|
👍 looks great—let's do it! |
|
Thanks @ericsuhn, this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the bramble extension files according to Thimble issue mozilla/thimble.mozilla.org#2581. Please let me know if this looks okay!