This repository has been archived by the owner on Jul 27, 2018. It is now read-only.
Support Alt-1 ... Alt-9 keyboard shortcuts. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const selectTab = advance(switchSelected, | ||
| indexOfSelected, | ||
| () => { return index - 1; }); |
|
On Mac, we need to use |
|
I fixed the naming and off by one thing. For the meta/alt, it's the same issue we have with alt + left to go back in history, ie. we need a better way to express os specific bindings. Can we do that in a follow-up? |
| @@ -67,7 +68,7 @@ define((require, exports, module) => { | |||
| 'accel right': goForward, | |||
| 'escape': stop, | |||
| 'accel r': reload, | |||
| 'F5': reload | |||
| 'F5': reload, | |||
There was a problem hiding this comment.
Nit: accidental comma? I'm ok with trailing commas but usually avoid them everywhere because of the allocation problems with arrays. Do we have a preference?
There was a problem hiding this comment.
that's not an array, and that makes cleaner diffs when you add items.
fabricedesre
force-pushed
the
keyboard-alt-1-9
branch
from
82d248b
to
1e87020
Compare
fabricedesre
added a commit
that referenced
this pull request
Mar 4, 2015
Support Alt-1 ... Alt-9 keyboard shortcuts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.