Revert to old-style data formats #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2014
|
Nothing springs to mind that you've missed, but it's been a long time since I've dug into the old data formats. If tests pass, and you can parse assertions from production Persona, then you're probably fine. |
|
Thanks Dan. So, things I'll sanity-check before we merge this:
If we can tick all those boxes we should be in good shape. |
This removes a bunch of work on "new format" certificates and assertions, which was designed to bring things into closer compliance with the JWT spec but was ultimately never deployed. It reduces complexity and maintenance burden by remove formats that will not be seen in the wild.
rfk
force-pushed
the
rfk/remove-new-cert-format
branch
from
edb53ab
to
045a65c
Compare
|
I've successfully tested the following combinations:
All seem to pass OK, so I think this is about as good as it'll get. @fmarier please r? for an extra set of eyes. |
|
Looks good -- the assertions really don't change, so as long as you're parsing / generating an RS and a DS key correctly, it should be set. |
|
Nice cleanup! r+ |
rfk
added a commit
that referenced
this pull request
Nov 6, 2014
Revert to old-style data formats as the only support format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my attempt at #97, removing the new-style JWT-compatible formats and reverting to the old-style format as the only option.
A rough list of the changes made to accomplish this:
@callahad what have I missed? :-)
I will test this with mozilla/fxa-auth-server#831 and a full fxa+sync stack deploy and report back.