Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jwcrypto dependency to v0.5.1 #35

Merged
merged 2 commits into from Sep 5, 2014
Merged

Conversation

rfk
Copy link
Contributor

@rfk rfk commented Sep 5, 2014

This updates the jwcrypto dependency to v0.5.1, which includes some changes to the way errors are reported:

  • It returns Error objects rather than strings; we should do the same here but for this deployment let's just normalize them back to strings
  • It no longer distinguishes between "certificate expired" and "assertion expired" in the error message

Let's get the latest into prod and then file a follow-up bug to keep improving the error/logging situation across all these projects.

@francois r?

@rfk
Copy link
Contributor Author

rfk commented Sep 5, 2014

Erm, I mean @fmarier r? and apologies to @francois for the noise :-)

@fmarier
Copy link
Contributor

fmarier commented Sep 5, 2014

Tests pass and code looks fine. r+

rfk added a commit that referenced this pull request Sep 5, 2014
Update jwcrypto dependency to v0.5.1
@rfk rfk merged commit 7f7dc7d into master Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants